Skip to content

Update highlight.js to 11.5.1 #2459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2022
Merged

Conversation

julienrf
Copy link
Contributor

@julienrf julienrf commented Jul 5, 2022

This brings better support for Scala 3 syntax highlighting.

You can find the release notes here: https://github.com/highlightjs/highlight.js/blob/main/VERSION_11_UPGRADE.md

This brings better support for Scala 3 syntax highlighting
@bishabosha
Copy link
Member

I have tried it out and a lot of examples are clearly better, such as extension methods and enum, but some edge cases seem to not work - still better than status quo

@julienrf
Copy link
Contributor Author

julienrf commented Jul 5, 2022

What are the examples that didn’t work?

@bishabosha
Copy link
Member

bishabosha commented Jul 5, 2022

from https://docs.scala-lang.org/scala3/book/types-adts-gadts.html#algebraic-datatypes-adts, but im not sure what happened here, other enums with type parameters look fine
Screenshot 2022-07-05 at 17 25 17

@julienrf julienrf merged commit acc196c into scala:main Jul 6, 2022
@julienrf julienrf deleted the update/highlight-js branch July 6, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants